mirror of
https://github.com/redhat-actions/push-to-registry.git
synced 2025-04-19 22:26:18 +02:00
Resolve reviews
Signed-off-by: divyansh42 <diagrawa@redhat.com>
This commit is contained in:
parent
bd321d175b
commit
27bd24ab9a
4 changed files with 8 additions and 8 deletions
|
@ -14,7 +14,7 @@ Push-to-registry is a GitHub Action for pushing a container image to an image re
|
|||
|
||||
This action only runs on Linux, as it uses [podman](https://github.com/containers/Podman) to perform the push. [GitHub's Ubuntu action runners](https://github.com/actions/virtual-environments#available-environments) come with Podman preinstalled. If you are not using those runners, you must first [install Podman](https://podman.io/getting-started/installation).
|
||||
|
||||
To log in against a container image registry, [**podman-login**](https://github.com/redhat-actions/podman-login) can be used.
|
||||
To log in to a container image registry, [**podman-login**](https://github.com/redhat-actions/podman-login) action can be used.
|
||||
|
||||
## Action Inputs
|
||||
|
||||
|
@ -73,7 +73,7 @@ jobs:
|
|||
dockerfiles: |
|
||||
./Dockerfile
|
||||
|
||||
# Podman Login action (https://github.com/redhat-actions/podman-login)ccan be used
|
||||
# Podman Login action (https://github.com/redhat-actions/podman-login) can be used
|
||||
# in the previous step to log in to a container registry. In that case input "username"
|
||||
# "password" can be omitted in this push action.
|
||||
- name: Push To quay.io
|
||||
|
|
2
dist/index.js
vendored
2
dist/index.js
vendored
File diff suppressed because one or more lines are too long
2
dist/index.js.map
vendored
2
dist/index.js.map
vendored
File diff suppressed because one or more lines are too long
|
@ -54,7 +54,7 @@ async function run(): Promise<void> {
|
|||
const tlsVerify = core.getInput(Inputs.TLS_VERIFY);
|
||||
const digestFileInput = core.getInput(Inputs.DIGESTFILE);
|
||||
|
||||
const inputExtraArgsStr = core.getInput("extra-args");
|
||||
const inputExtraArgsStr = core.getInput(Inputs.EXTRA_ARGS);
|
||||
let podmanExtraArgs: string[] = [];
|
||||
if (inputExtraArgsStr) {
|
||||
// transform the array of lines into an array of arguments
|
||||
|
@ -160,10 +160,10 @@ async function run(): Promise<void> {
|
|||
|
||||
let creds = "";
|
||||
if (username && !password) {
|
||||
core.warning("Username is provided, but password is missing!");
|
||||
core.warning("Username is provided, but password is missing");
|
||||
}
|
||||
else if (!username && password) {
|
||||
core.warning("Password is provided, but username is missing!");
|
||||
core.warning("Password is provided, but username is missing");
|
||||
}
|
||||
else if (username && password) {
|
||||
creds = `${username}:${password}`;
|
||||
|
|
Loading…
Add table
Reference in a new issue