Resolve reviews

Signed-off-by: divyansh42 <diagrawa@redhat.com>
This commit is contained in:
divyansh42 2021-11-13 09:44:44 +05:30
parent 27553499f0
commit 14674baabe
5 changed files with 5 additions and 6 deletions

View file

@ -60,7 +60,7 @@ jobs:
containerfiles: |
./Containerfile
# Push the image to Quay.io (Image Registry)
# Push the image manifest to Quay.io (Image Registry)
- name: Push To Quay
uses: ./
id: push

View file

@ -85,8 +85,7 @@ For example:
## Pushing Manifest
This action supports manifest, this means you can push the manifest with this action.
Input `image` and `tags` can be used for manifest also. Provided you can either push manifest or container image, not both of them together.
If multiple tags are provided, either all tags must point to manifests, or none of them. i.e., you cannot push both manifests are regular images in one `push-to-registry` step.
Refer to [Manifest Build and Push example](./github/workflows/manifest-build-push.yaml) for a sophisticated example of building and pushing a manifest.

2
dist/index.js vendored

File diff suppressed because one or more lines are too long

2
dist/index.js.map vendored

File diff suppressed because one or more lines are too long

View file

@ -427,7 +427,7 @@ async function checkIfManifestsExists(): Promise<boolean> {
if (foundManifests.length > 0) {
core.info(`Image${foundManifests.length !== 1 ? "s" : ""} "${foundManifests.join(", ")}" `
+ `${foundManifests.length !== 1 ? "are" : "is"} manifests.`);
+ `${foundManifests.length !== 1 ? "are manifests" : "is a manifest"}.`);
}
if (foundManifests.length > 0 && missingManifests.length > 0) {