From 0fa2dca2e82bfcd1d47bfec957d0745f343cfa5e Mon Sep 17 00:00:00 2001 From: EusebioTrigo Date: Tue, 5 Mar 2024 14:48:07 +0100 Subject: [PATCH] Support/node20 (#93) * Update action.yml to use node20 * Update README.md with newer runner versions and fix typo * Update all workflows to use newer action versions and runner environments --- .github/workflows/check-lowercase.yaml | 4 ++-- .github/workflows/ci.yml | 10 +++++----- .github/workflows/ghcr-push.yaml | 4 ++-- .github/workflows/link_check.yml | 4 ++-- .github/workflows/manifest-build-push.yaml | 6 +++--- .github/workflows/multiple-build.yaml | 4 ++-- .github/workflows/quay-push.yaml | 4 ++-- .github/workflows/security_scan.yml | 8 ++++---- .github/workflows/verify-login-push.yml | 4 ++-- README.md | 10 +++++----- action.yml | 4 ++-- 11 files changed, 31 insertions(+), 31 deletions(-) diff --git a/.github/workflows/check-lowercase.yaml b/.github/workflows/check-lowercase.yaml index 95a7a9b..5353f59 100644 --- a/.github/workflows/check-lowercase.yaml +++ b/.github/workflows/check-lowercase.yaml @@ -17,7 +17,7 @@ env: jobs: push-ghcr: name: Build and push image - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 strategy: fail-fast: false matrix: @@ -26,7 +26,7 @@ jobs: steps: # Checkout push-to-registry action github repository - name: Checkout Push to Registry action - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install latest podman if: matrix.install_latest diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3a7dfe5..e4ef0cb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,18 +9,18 @@ jobs: runs-on: ubuntu-20.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - run: npm ci - run: npm run lint check-dist: name: Check Distribution - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 env: BUNDLE_FILE: "dist/index.js" BUNDLE_COMMAND: "npm run bundle" steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Install run: npm ci @@ -33,11 +33,11 @@ jobs: check-inputs-outputs: name: Check Input and Output enums - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 env: IO_FILE: ./src/generated/inputs-outputs.ts steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Install dependencies run: npm ci diff --git a/.github/workflows/ghcr-push.yaml b/.github/workflows/ghcr-push.yaml index 40160f2..11154f2 100644 --- a/.github/workflows/ghcr-push.yaml +++ b/.github/workflows/ghcr-push.yaml @@ -17,7 +17,7 @@ env: jobs: push-ghcr: name: Build and push image - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 strategy: fail-fast: false matrix: @@ -26,7 +26,7 @@ jobs: steps: # Checkout push-to-registry action github repository - name: Checkout Push to Registry action - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install latest podman if: matrix.install_latest diff --git a/.github/workflows/link_check.yml b/.github/workflows/link_check.yml index bc84d77..c949ec7 100644 --- a/.github/workflows/link_check.yml +++ b/.github/workflows/link_check.yml @@ -12,9 +12,9 @@ on: jobs: markdown-link-check: name: Check links in markdown - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - uses: gaurav-nelson/github-action-markdown-link-check@v1 with: use-verbose-mode: true diff --git a/.github/workflows/manifest-build-push.yaml b/.github/workflows/manifest-build-push.yaml index bbc5a09..fb79c0c 100644 --- a/.github/workflows/manifest-build-push.yaml +++ b/.github/workflows/manifest-build-push.yaml @@ -17,7 +17,7 @@ env: jobs: push-quay: name: Build and push manifest - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 strategy: fail-fast: false matrix: @@ -26,7 +26,7 @@ jobs: steps: # Checkout push-to-registry action github repository - name: Checkout Push to Registry action - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install latest podman if: matrix.install_latest @@ -51,7 +51,7 @@ jobs: - name: Build Image id: build_image - uses: redhat-actions/buildah-build@main + uses: redhat-actions/buildah-build@v2 with: image: ${{ env.IMAGE_NAME }} tags: ${{ env.IMAGE_TAGS }} diff --git a/.github/workflows/multiple-build.yaml b/.github/workflows/multiple-build.yaml index 147202e..4ed0260 100644 --- a/.github/workflows/multiple-build.yaml +++ b/.github/workflows/multiple-build.yaml @@ -17,7 +17,7 @@ jobs: build: name: |- Build with ${{ matrix.build_with }} and push${{ matrix.fully_qualified_image_name_tag && ' FQIN' || '' }} (latest: ${{ matrix.install_latest }}) - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 strategy: fail-fast: false matrix: @@ -29,7 +29,7 @@ jobs: # Checkout push-to-registry action github repository - name: Checkout Push to Registry action - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install latest podman if: matrix.install_latest diff --git a/.github/workflows/quay-push.yaml b/.github/workflows/quay-push.yaml index e8324b1..eac4d0f 100644 --- a/.github/workflows/quay-push.yaml +++ b/.github/workflows/quay-push.yaml @@ -17,7 +17,7 @@ env: jobs: push-quay: name: Build and push image - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 strategy: fail-fast: false matrix: @@ -26,7 +26,7 @@ jobs: steps: # Checkout push-to-registry action github repository - name: Checkout Push to Registry action - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install latest podman if: matrix.install_latest diff --git a/.github/workflows/security_scan.yml b/.github/workflows/security_scan.yml index d045279..1ba5071 100644 --- a/.github/workflows/security_scan.yml +++ b/.github/workflows/security_scan.yml @@ -9,16 +9,16 @@ on: jobs: crda-scan: - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 name: Scan project vulnerability with CRDA steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Setup Node - uses: actions/setup-node@v2 + uses: actions/setup-node@v4 with: - node-version: '14' + node-version: '20' - name: Install CRDA uses: redhat-actions/openshift-tools-installer@v1 diff --git a/.github/workflows/verify-login-push.yml b/.github/workflows/verify-login-push.yml index 39e3a4a..a82fde4 100644 --- a/.github/workflows/verify-login-push.yml +++ b/.github/workflows/verify-login-push.yml @@ -17,7 +17,7 @@ env: jobs: login-and-push: name: Login and push image to Quay.io - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 strategy: fail-fast: false matrix: @@ -27,7 +27,7 @@ jobs: # Checkout push-to-registry action github repository - name: Checkout Push to Registry action - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Install latest podman if: matrix.install_latest diff --git a/README.md b/README.md index 6503e15..1250b8f 100644 --- a/README.md +++ b/README.md @@ -101,10 +101,10 @@ on: [ push ] jobs: build: name: Build and push image - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Build Image id: build-image @@ -144,13 +144,13 @@ If the image to push is present in both the Docker and Podman image storage, the If the action pulled an image from the Docker image storage into the Podman storage, it will be cleaned up from the Podman storage before the action exits. ## Note about GitHub runners and Podman -We recommend using `runs-on: ubuntu-20.04` since it has a newer version of Podman. +We recommend using `runs-on: ubuntu-22.04` since it has a newer version of Podman. -If you are on `ubuntu-18.04` or any other older versions of ubuntu your workflow will use an older version of Podman and may encounter issues such as [#26](https://github.com/redhat-actions/push-to-registry/issues/26). +If you are on `ubuntu-20.04` or any other older versions of ubuntu your workflow will use an older version of Podman and may encounter issues such as [#26](https://github.com/redhat-actions/push-to-registry/issues/26). ## Troubleshooting Note that quay.io repositories are private by default.
This means that if you push an image for the first time, you will have to authenticate before pulling it, or go to the repository's settings and change its visibility. -Simiarly, if you receive a 403 Forbidden from GHCR, you may have to update the Package Settings. Refer to [this issue](https://github.com/redhat-actions/push-to-registry/issues/52). +Similarly, if you receive a 403 Forbidden from GHCR, you may have to update the Package Settings. Refer to [this issue](https://github.com/redhat-actions/push-to-registry/issues/52). diff --git a/action.yml b/action.yml index 4953e72..b3f3b3b 100644 --- a/action.yml +++ b/action.yml @@ -11,7 +11,7 @@ inputs: tags: description: | 'The tag or tags of the image/manifest to push. - For multiple tags, seperate by whitespace. For example, "latest v1"' + For multiple tags, separate by whitespace. For example, "latest v1"' required: false default: 'latest' registry: @@ -47,5 +47,5 @@ outputs: registry-paths: description: 'A JSON array of registry paths to which the tag(s) were pushed' runs: - using: 'node16' + using: 'node20' main: 'dist/index.js'