Update changelog

Signed-off-by: divyansh42 <diagrawa@redhat.com>

.github/workflows/ci.yml

@@ -8,21 +8,21 @@ on:
 jobs:
   lint:
     name: Run ESLint
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - run: npm ci
       - run: npm run lint
 
   check-dist:
     name: Check Distribution
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     env:
       BUNDLE_FILE: "dist/index.js"
       BUNDLE_COMMAND: "npm run bundle"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install
         run: npm ci
@@ -35,11 +35,11 @@ jobs:
 
   check-inputs-outputs:
     name: Check Input and Output enums
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     env:
       IO_FILE: ./src/generated/inputs-outputs.ts
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Install dependencies
         run: npm ci

.github/workflows/example.yml

@@ -15,7 +15,7 @@ env:
 jobs:
   podman-pull:
     name: Log in and pull image with Podman
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
@@ -23,7 +23,7 @@ jobs:
 
     steps:
 
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Install latest podman
         if: matrix.install_latest
@@ -43,14 +43,14 @@ jobs:
 
   buildah-pull:
     name: Log in and pull image with Buildah
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
         install_latest: [ true, false ]
     steps:
 
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Install latest podman
         if: matrix.install_latest
@@ -69,14 +69,14 @@ jobs:
 
   docker-pull:
     name: Log in and pull image with Docker
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     strategy:
       fail-fast: false
       matrix:
         install_latest: [ true, false ]
     steps:
 
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
 
       - name: Install latest podman
         if: matrix.install_latest

.github/workflows/link_check.yml

@@ -12,9 +12,9 @@ on:
 jobs:
   markdown-link-check:
     name: Check links in markdown
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: gaurav-nelson/github-action-markdown-link-check@v1
         with:
           use-verbose-mode: true

.github/workflows/security_scan.yml

@@ -1,24 +1,24 @@
 name: Vulnerability Scan with CRDA
 on:
-  push:
+  # push:
   workflow_dispatch:
-  pull_request_target:
-    types: [ assigned, opened, synchronize, reopened, labeled, edited ]
-  schedule:
-    - cron: '0 0 * * *'  # every day at midnight
+  # pull_request_target:
+  #   types: [ assigned, opened, synchronize, reopened, labeled, edited ]
+  # schedule:
+  #   - cron: '0 0 * * *'  # every day at midnight
 
 jobs:
   crda-scan:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     name: Scan project vulnerability with CRDA
     steps:
 
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
 
       - name: Setup Node
         uses: actions/setup-node@v2
         with:
-          node-version: '16'
+          node-version: '20'
 
       - name: Install CRDA
         uses: redhat-actions/openshift-tools-installer@v1

.gitignore

@@ -1,2 +1,3 @@
 node_modules/
-out/
+out/
+.idea/

CHANGELOG.md

@@ -1,5 +1,11 @@
 # podman-login Changelog
 
+## v1.7
+- Update action to run on Node20.https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
+
+## v1.6
+- Update action/core dependency to 1.10.0
+
 ## v1.5
 - Update action to run on Node16. https://github.blog/changelog/2022-05-20-actions-can-now-run-in-a-node-js-16-runtime/
 

action.yml

@@ -25,6 +25,6 @@ inputs:
     default: 'true'
 
 runs:
-  using: 'node16'
+  using: 'node20'
   main: 'dist/index.js'
   post: 'dist/index.js'

package.json

@@ -2,7 +2,7 @@
   "name": "podman-login",
   "version": "1.0.0",
   "engines": {
-    "node": "16"
+    "node": "20"
   },
   "description": "GitHub Action to log in against a container image registry",
   "repository": {
@@ -21,21 +21,21 @@
   "author": "Red Hat",
   "license": "MIT",
   "dependencies": {
-    "@actions/core": "^1.9.1",
-    "@actions/exec": "^1.0.4",
-    "@actions/io": "^1.0.2",
-    "@aws-sdk/client-ecr": "^3.100.0",
-    "@aws-sdk/util-base64": "^3.208.0"
+    "@actions/core": "^1.10.1",
+    "@actions/exec": "^1.1.1",
+    "@actions/io": "^1.1.3",
+    "@aws-sdk/client-ecr": "^3.535.0",
+    "@aws-sdk/util-base64": "^3.310.0"
   },
   "devDependencies": {
     "@redhat-actions/action-io-generator": "^1.5.0",
-    "@redhat-actions/eslint-config": "^1.2.11",
-    "@redhat-actions/tsconfig": "^1.1.1",
-    "@types/node": "^12",
-    "@typescript-eslint/eslint-plugin": "^4.14.1",
-    "@typescript-eslint/parser": "^4.14.1",
-    "@vercel/ncc": "^0.25.1",
-    "eslint": "^7.18.0",
-    "typescript": "^4.0.5"
+    "@redhat-actions/eslint-config": "^1.3.2",
+    "@redhat-actions/tsconfig": "^1.2.0",
+    "@types/node": "^20",
+    "@typescript-eslint/eslint-plugin": "^7.2.0",
+    "@typescript-eslint/parser": "^7.2.0",
+    "@vercel/ncc": "^0.38.1",
+    "eslint": "^8.57.0",
+    "typescript": "^5.4.2"
   }
 }

src/index.ts

@@ -71,12 +71,12 @@ async function run(): Promise<void> {
         podmanAuthFilePath = authFilePath;
     }
     else {
-        let authFileDir = path.join("/", "tmp", `podman-run-${process.getuid()}`);
+        // process.getuid might be undefined
+        let authFileDir = path.join("/", "tmp", `podman-run-${process.getuid ? process.getuid() : null}`);
         if (process.env.XDG_RUNTIME_DIR) {
             authFileDir = process.env.XDG_RUNTIME_DIR;
         }
-        podmanAuthFilePath = path.join(authFileDir,
-            "containers", "auth.json");
+        podmanAuthFilePath = path.join(authFileDir, "containers", "auth.json");
     }
     const REGISTRY_AUTH_ENVVAR = "REGISTRY_AUTH_FILE";
     core.info(`Exporting ${REGISTRY_AUTH_ENVVAR}=${podmanAuthFilePath}`);

src/utils.ts

@@ -69,5 +69,6 @@ export async function execute(
 
 export async function getDockerConfigJson(): Promise<string> {
     const dockerConfigPath = path.join(os.homedir(), ".docker", "config.json");
-    return fs.readFile(dockerConfigPath, "utf-8");
+    return fs.readFile(dockerConfigPath, "utf-8")
+        .catch((err) => { if (err.code === "ENOENT") { return `{"auths":{}}`; } throw err; });
 }