Update code

Signed-off-by: divyansh42 <diagrawa@redhat.com>

.github/workflows/example.yml

@@ -9,8 +9,8 @@ env:
   REGISTRY_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }}
 
 jobs:
-  build-and-push:
+  login:
-    name: Build and push image to Quay.io
+    name: Login to container image registry
     runs-on: ubuntu-20.04
     steps:
 
@@ -25,12 +25,3 @@ jobs:
           password: ${{ env.REGISTRY_PASSWORD }}
           registry: ${{ env.IMAGE_REGISTRY }}
           logout: true
-
-      # - name: Verify
-      #   shell: bash
-      #   run: |
-      #     pwd
-      #     ls $HOME
-      #     cd $HOME
-      #     tree work
-      #     cat ${XDG_RUNTIME_DIR}/containers/auth.json

action.yml

@@ -1,21 +1,21 @@
 name: 'Podman login'
-description: 'GitHub Action to login against a container registry'
+description: 'GitHub Action to login against a container image registry'
 author: 'Red Hat'
 branding:
   icon: circle
   color: red
 inputs:
   registry:
-    description: 'Server address of Docker registry. If not set then will default to Docker Hub'
+    description: 'Server URL of the container image registry'
-    required: false
+    required: true
   username:
-    description: 'Username used to log against the Docker registry'
+    description: 'Username to login against the container image registry'
     required: false
   password:
-    description: 'Password or personal access token used to log against the Docker registry'
+    description: 'Password to login against the container image registry'
     required: false
   logout:
-    description: 'Set to true if you want to logout once the workflows completes'
+    description: 'Set to true if you want to logout at the end of the job'
     required: false
     default: 'false'
 

package.json

@@ -4,7 +4,7 @@
   "engines": {
     "node": "12"
   },
-  "description": "GitHub Action to login against a container registry",
+  "description": "GitHub Action to login against a container image registry",
   "repository": {
     "type": "git",
     "url": "https://github.com/redhat-actions/podman-login"

src/generated/inputs-outputs.ts

@@ -1,25 +1,25 @@
 // This file was auto-generated by action-io-generator. Do not edit by hand!
 export enum Inputs {
     /**
-     * Set to true if you want to logout once the workflows completes
+     * Set to true if you want to logout at the end of the job
      * Required: false
      * Default: "false"
      */
     LOGOUT = "logout",
     /**
-     * Password or personal access token used to log against the Docker registry
+     * Password to login against the container image registry
      * Required: false
      * Default: None.
      */
     PASSWORD = "password",
     /**
-     * Server address of Docker registry. If not set then will default to Docker Hub
+     * Server URL of the container image registry
-     * Required: false
+     * Required: true
      * Default: None.
      */
     REGISTRY = "registry",
     /**
-     * Username used to log against the Docker registry
+     * Username to login against the container image registry
      * Required: false
      * Default: None.
      */

src/index.ts

@@ -8,7 +8,7 @@ import * as io from "@actions/io";
 import * as os from "os";
 import { getInputs } from "./context";
 import { execute } from "./utils";
-import * as stateHelper from './state-helper';
+import * as stateHelper from "./state-helper";
 
 let podmanPath: string | undefined;
 
@@ -23,13 +23,14 @@ async function getPodmanPath(): Promise<string> {
 
 async function run(): Promise<void> {
     if (os.platform() !== "linux") {
-        throw new Error("Only supported on linux platform");
+        throw new Error("❌ Only supported on linux platform");
     }
 
     const {
-        registry, username, password, logout,
+        registry, username, password, logout,  // eslint-disable-line @typescript-eslint/no-shadow
     } = getInputs();
 
+    stateHelper.setRegistry(registry);
     stateHelper.setLogout(logout);
 
     const args = [
@@ -43,22 +44,18 @@ async function run(): Promise<void> {
 
     await execute(await getPodmanPath(), args);
     core.info(`✅ Successfully logged in to ${registry}`);
-
-    // if (logout) {
-    //     await execute(await getPodmanPath(), [ "logout", registry ]);
-    // }
 }
 
 async function logout(): Promise<void> {
     if (!stateHelper.logout) {
         return;
-      }
+    }
-    await execute(await getPodmanPath(), [ "logout", "quay.io" ]);
+    await execute(await getPodmanPath(), [ "logout", stateHelper.registry ]);
 }
 
 if (!stateHelper.IsPost) {
-    run().catch(core.setFailed);;
+    run().catch(core.setFailed);
 }
 else {
-    logout().catch(core.setFailed);;
+    logout().catch(core.setFailed);
 }

src/state-helper.ts

@@ -1,17 +1,21 @@
-import * as core from '@actions/core';
+import * as core from "@actions/core";
 
-export const IsPost = !!process.env['STATE_isPost'];
+/* eslint-disable dot-notation */
-// export const registry = process.env['STATE_registry'] || '';
+export const IsPost = !!process.env["STATE_isPost"];
-export const logout = /true/i.test(process.env['STATE_logout'] || '');
+export const registry = process.env["STATE_registry"] || "";
+export const logout = /true/i.test(process.env["STATE_logout"] || "");
+/* eslint-enable dot-notation */
 
-// export function setRegistry(registry: string) {
+// eslint-disable-next-line @typescript-eslint/no-shadow
-//   core.saveState('registry', registry);
+export function setRegistry(registry: string): void {
-// }
+    core.saveState("registry", registry);
+}
 
-export function setLogout(logout: string) {
+// eslint-disable-next-line @typescript-eslint/no-shadow
-  core.saveState('logout', logout);
+export function setLogout(logout: string): void {
+    core.saveState("logout", logout);
 }
 
 if (!IsPost) {
-  core.saveState('isPost', 'true');
+    core.saveState("isPost", "true");
 }